Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BA-674): Implement Image Soft/Hard Delete APIs #3628

Open
wants to merge 14 commits into
base: topic/02-10-feat_add_status_to_image_imagenode_gql_field
Choose a base branch
from
Open

feat(BA-674): Implement Image Soft/Hard Delete APIs #3628

wants to merge 14 commits into from
+144 −55

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Feb 10, 2025 •
edited by github-actions bot
Loading

Resolves #3617 (BA-674)

Changes

Added CLI commands

  • mgr image purge

Updated CLI commands

  • mgr image forget

Added mutations

  • PurgeImageById
  • PurgeImage

Updated mutations

  • ForgetImageById
  • ForgetImage
  • ClearImages

Note

There is no Image REST API, so it has been omitted.

Checklist: (if applicable)

  • Mention to the original issue
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--3628.org.readthedocs.build/en/3628/

📚 Documentation preview 📚: https://sorna-ko--3628.org.readthedocs.build/ko/3628/

@github-actions github-actions bot added comp:manager Related to Manager component size:L 100~500 LoC labels Feb 10, 2025
@jopemachine jopemachine mentioned this pull request Feb 10, 2025
Open
1 task
@jopemachine Graphite App
Copy link
Member Author

jopemachine commented Feb 10, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jopemachine jopemachine mentioned this pull request Feb 10, 2025
Open
1 task
@jopemachine jopemachine changed the title feat: Implment Image Soft/Hard Delete APIs feat: Implement Image Soft/Hard Delete APIs Feb 10, 2025
@jopemachine jopemachine changed the title feat: Implement Image Soft/Hard Delete APIs feat(BA-674): Implement Image Soft/Hard Delete APIs Feb 10, 2025
@github-actions github-actions bot added the area:docs Documentations label Feb 10, 2025
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 55c29b4 to 574e5d7 Compare February 10, 2025 04:53
@jopemachine jopemachine added this to the 25Q1 milestone Feb 10, 2025
@jopemachine jopemachine mentioned this pull request Feb 11, 2025
Open
1 task
@github-actions github-actions bot added comp:client Related to Client component comp:cli Related to CLI component labels Feb 11, 2025
@jopemachine
Copy link
Member Author

jopemachine commented Feb 17, 2025 •
edited
Loading

I think mgr image purge -> mgr image purge-row make sense if we also integrate image deletion feature as CLI command.

What do you think about this naming? @HyeockJinKim

@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 6c6e0de to 4403c81 Compare February 17, 2025 05:47
@jopemachine jopemachine force-pushed the topic/02-10-feat_add_status_to_image_imagenode_gql_field branch from f9e97c4 to 2709c9e Compare February 17, 2025 05:47
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 4403c81 to abe5f22 Compare February 17, 2025 05:57
@jopemachine jopemachine force-pushed the topic/02-10-feat_add_status_to_image_imagenode_gql_field branch from 2709c9e to 65e082e Compare February 17, 2025 05:57
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from abe5f22 to fdd6902 Compare February 17, 2025 06:01
@jopemachine jopemachine force-pushed the topic/02-10-feat_add_status_to_image_imagenode_gql_field branch from 65e082e to b78befd Compare February 17, 2025 06:01
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from fdd6902 to cdf1e63 Compare February 18, 2025 03:35
@jopemachine jopemachine marked this pull request as ready for review February 18, 2025 03:37
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch 3 times, most recently from 581d7ce to f75988e Compare February 18, 2025 05:37
@jopemachine jopemachine force-pushed the topic/02-10-feat_add_status_to_image_imagenode_gql_field branch from b4aa052 to a7d872c Compare February 18, 2025 05:37
HyeockJinKim
HyeockJinKim reviewed Feb 18, 2025
View reviewed changes
docs/manager/graphql-reference/schema.graphql Outdated
purge_image_by_id(image_id: String!): PurgeImageById

"""Added in 25.3.1"""
purge_image(architecture: String = "x86_64", reference: String!): PurgeImage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between purge_image_by_id?

Copy link
Member Author

@jopemachine jopemachine Feb 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

purge_image is an API that deletes an image using its name as a string,
whereas purge_image_by_id directly deletes an image using its image_id (DB ID).
It follows the same structure as forget_image and forget_image_by_id.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's nice to gradually deprecate the name-based APIs.

@github-actions github-actions bot added the comp:common Related to Common component label Feb 19, 2025
@jopemachine jopemachine force-pushed the topic/02-10-feat_add_status_to_image_imagenode_gql_field branch from a7d872c to fcae57e Compare February 19, 2025 04:57
@jopemachine jopemachine force-pushed the topic/02-10-feat_implment_image_soft_hard_delete_apis branch from 6484405 to ad292e6 Compare February 19, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim left review comments

Assignees

@jopemachine jopemachine

Labels
area:docs Documentations comp:cli Related to CLI component comp:client Related to Client component comp:common Related to Common component comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Milestone
25Q1
Development

Successfully merging this pull request may close these issues.
2 participants
@jopemachine @HyeockJinKim